feat(gcssource): add support for a GCS bucket source #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blobs in GCS are expected to be plain passwd, group, and shadow files so the FilesMapParser can be used.
jaqx0r
previously approved these changes
Apr 19, 2023
This comment has been minimized.
This comment has been minimized.
The blobs in GCS are expected to be plain passwd, group, and shadow files so the FilesMapParser can be used.
auto-merge was automatically disabled
April 19, 2023 23:56
Head branch was pushed to by a user without write access
jaqx0r
previously approved these changes
Apr 20, 2023
|
Can you please format to appease yapf |
jaqx0r
approved these changes
Apr 20, 2023
This comment has been minimized.
This comment has been minimized.
Unit Test Results 1 files 1 suites 2s ⏱️ Results for commit 311a93a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/google/nsscache/blob/main/nss_cache/sources/s3source.py and https://github.com/google/nsscache/blob/main/nss_cache/sources/httpsource.py.
I can't tell exactly what the file format is for files saved in S3, but I want the gcssource to consume "raw" passwd/group/shadow files like how the HTTP source works.