Add 6 new APIs (to pooling and image) and document many missing APIs. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntries. Added new APIs: space_to_batch2d, space_to_channel2d, batch_to_space2d, channel_to_space2d, normalize_to_uint8, normalize_to_unit_float (with docs and tests).
| output tensor of shape (N // (size[0] * size[1]), C, H * size[0], W * size[1]). | ||
| """ | ||
| size = to_tuple(size, 2) | ||
| s = x.shape |
There was a problem hiding this comment.
maybe add assert len(x.shape) == 4 to prevent users accidentally calling it for wrong number of dimentions
also add same assert in other functions
There was a problem hiding this comment.
I'm unsure about introduction of asserts everywhere. This is outside of the scope of this change, we should discuss it separately.
…ntries. Added new APIs: space_to_batch2d, space_to_channel2d, batch_to_space2d, channel_to_space2d, normalize_to_uint8, normalize_to_unit_float (with docs and tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.