Adding a Copy Constructor to AudioStreamBuilder #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from existing AudioStream. Fixes #527.
philburk
reviewed
May 30, 2019
| if (error == oboe::Result::ErrorDisconnected) restartStream(); | ||
| if (error == oboe::Result::ErrorDisconnected) { | ||
| oboe::AudioStreamBuilder builder_ = oboe::AudioStreamBuilder(*oboeStream); | ||
| restartStream(&builder_); |
There was a problem hiding this comment.
Do we leak the old AudioStream pointer?
If you delete it then you may hit this issue!
#519
There was a problem hiding this comment.
Restarting will use the same pointer, mPlayStream, but create a new object. The old object is closed but not deleted, however, I think this issue should be addressed by using a unique pointer, which involves issue #529
* Moved duplex stream to live effect * LiveEffect refactor with full duplex stream completely functional. Fixes #60 * Preserving comments and naming conventions. Also making duplex passthrough more resilient.
* Audio Engine needs to be reinitialized on app start, using pointer instead of object * shared Mixer refactored to use raw pointers instead of shared pointers. This refactor impacted MegaDrone and RhythmGame. This prevents ambiguous ownership of audio components, leaving the owner of the Mixer as the sole owner of the inputs to the Mixer. This allows for objects with the Mixer as a member along with its inputs to control their duration automatically, in aggregate. This fixes crashes on destruction of objects composing the Mixer and various inputs. (E.g. Fixes #521). * Refactoring use of unique ptr in RhythmGame and const ptr in MegaDrone * Documenting mixer input ownership * Removing const pointer since it requires a messy ternary
from existing AudioStream. Fixes #527.
philburk
reviewed
Jun 3, 2019
| void *audioData, | ||
| int numFrames) override; | ||
|
|
||
| int32_t getMNumInputBurstsCushion() const; |
There was a problem hiding this comment.
remove 'M' from getMNum and setMNum...
| * | ||
| * @param mNumInputBurstsCushion | ||
| */ | ||
| void setMNumInputBurstsCushion(int32_t mNumInputBurstsCushion); |
There was a problem hiding this comment.
parameter should starts with "num"
| static constexpr int32_t kNumCallbacksToDiscard = 30; | ||
|
|
||
| // let input fill back up, usually 0 or 1 | ||
| int32_t mNumInputBurstsCushion = 1; |
There was a problem hiding this comment.
align with other m variables
|
|
||
| /** | ||
| * Called when data is available on both streams. | ||
| * Caller should override this method. |
|
|
||
| /** | ||
| * Called by Oboe when the stream is ready to process audio. | ||
| */ |
There was a problem hiding this comment.
Add "This implements the stream synchronization. App should NOT override this method."
|
Do I need to roll back the rebase? |
philburk
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #527 for more details.