Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: OR-Tools use a custom absl:string_view based version of RE2 #3201

Closed
Mizux opened this issue Mar 21, 2022 · 3 comments
Closed

C++: OR-Tools use a custom absl:string_view based version of RE2 #3201

Mizux opened this issue Mar 21, 2022 · 3 comments
Assignees
@Mizux
Labels
Bug Feature Request Missing Feature/Wrapper Lang: C++ Native implementation issue
Milestone
v9.4

Comments

@Mizux
Copy link
Collaborator

Mizux commented Mar 21, 2022 •
edited
Loading

Currently OR-Tools use a custom version of RE2 using absl::string_view instead of re2::StringPiece unfortunatelly this make difficult for the OSS community to integrate or-tools against a system wide installation of re2...

ref: https://github.com/google/or-tools/blob/stable/patches/re2-2021-11-01.patch
@Mizux Mizux added Bug Feature Request Missing Feature/Wrapper Lang: C++ Native implementation issue labels Mar 21, 2022
@Mizux Mizux added this to the v9.4 milestone Mar 21, 2022
@Mizux Mizux self-assigned this Mar 21, 2022
@Mizux Mizux changed the title OR-Tools use a absl based version of RE2 OR-Tools use an absl:string_view based version of RE2 Mar 21, 2022
Mizux added a commit that referenced this issue Mar 21, 2022
@Mizux
ci: Add jobs to test compile without lp_parser (#3201)
49783b4
Mizux added a commit that referenced this issue Mar 22, 2022
@Mizux
ci: Add jobs to test compile without lp_parser (#3201)
89505a8
Mizux added a commit that referenced this issue Mar 23, 2022
@Mizux
ci: Add jobs to test compile without lp_parser (#3201)
50ae683
@Mizux
Copy link
Collaborator Author

Mizux commented Mar 23, 2022 •
edited
Loading

Seems if RE2 compiled in C++17, it should have support for string_view...
see:
https://github.com/google/re2/blob/4c7b561f1f2784fea7a4ac415575c3b080518006/re2/stringpiece.h#L55-L58

Macro name Feature Value Header Std
__cpp_lib_string_view std::string_view 201606L <string>
<string_view>		 ( C++17)
__cpp_lib_string_view ConstexprIterator 201803L <string>
<string_view>		 (C++20)

std::string_view
<string>
<string_view>
ConstexprIterator

ref: https://en.cppreference.com/w/cpp/feature_test

Mizux added a commit that referenced this issue Mar 23, 2022
@Mizux
ci: Add jobs to test compile without lp_parser (#3201)
b649c3b
Mizux added a commit that referenced this issue Mar 24, 2022
@Mizux
ci: Add jobs to test compile without lp_parser (#3201)
dcba31c
Mizux added a commit that referenced this issue Mar 24, 2022
@Mizux
ci: Add jobs to test compile without lp_parser (#3201)
0110b8c
@Mizux Mizux changed the title OR-Tools use an absl:string_view based version of RE2 c++: OR-Tools use a custom absl:string_view based version of RE2 Mar 24, 2022
Mizux added a commit that referenced this issue Mar 24, 2022
@Mizux
c++: use legacy RE2 (#3201)
23a295f
Mizux added a commit that referenced this issue Mar 24, 2022
@Mizux
c++: Add USE_LP_PARSER define (#3201)
c505f3d
Mizux added a commit that referenced this issue Mar 24, 2022
@Mizux
ci: Add jobs to test compile without lp_parser (#3201)
2f8995c
@Mizux Mizux changed the title c++: OR-Tools use a custom absl:string_view based version of RE2 C++: OR-Tools use a custom absl:string_view based version of RE2 Mar 24, 2022
Mizux added a commit that referenced this issue Mar 24, 2022
@Mizux
c++: use legacy RE2 (#3201)
3cb2885
Mizux added a commit that referenced this issue Mar 24, 2022
@Mizux
c++: Add USE_LP_PARSER define (#3201)
0506f48
Mizux added a commit that referenced this issue Mar 24, 2022
@Mizux
ci: Add jobs to test compile without lp_parser (#3201)
cff7538
Mizux added a commit that referenced this issue Mar 25, 2022
@Mizux
c++: use legacy RE2 (#3201)
0d3572b
Mizux added a commit that referenced this issue Mar 25, 2022
@Mizux
c++: Add USE_LP_PARSER define (#3201)
3c6f88d
Mizux added a commit that referenced this issue Mar 25, 2022
@Mizux
ci: Add jobs to test compile without lp_parser (#3201)
f2ac266
@Mizux Mizux closed this as completed Mar 30, 2022
@Mizux Mizux mentioned this issue Apr 2, 2022
Closed
3 tasks
@StefanBruens
Copy link
Contributor

As far as I can see, this has not been merged, nor is there any open PR.

@Mizux
Copy link
Collaborator Author

Mizux commented Apr 25, 2022 •
edited
Loading

@StefanBruens AFAIK this has been pushed on master...
see: 0d3572b

@andreas-schwab andreas-schwab mentioned this issue Jun 4, 2022
Closed
@Mizux Mizux mentioned this issue Aug 9, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mizux Mizux

Labels
Bug Feature Request Missing Feature/Wrapper Lang: C++ Native implementation issue
Projects
None yet
Milestone
v9.4
Development

No branches or pull requests
2 participants
@StefanBruens @Mizux