Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken libxml2 build #822

Closed
Dor1s opened this issue Sep 6, 2017 · 4 comments
Closed

Broken libxml2 build #822

Dor1s opened this issue Sep 6, 2017 · 4 comments
Assignees

Comments

@Dor1s
Copy link
Contributor

Dor1s commented Sep 6, 2017

https://oss-fuzz-build-logs.storage.googleapis.com/index.html

Step #4: + check_startup_crash /workspace/out/address/libxml2_xml_regexp_compile_fuzzer
Step #4: + local FUZZER=/workspace/out/address/libxml2_xml_regexp_compile_fuzzer
Step #4: + local CHECK_PASSED=0
Step #4: + [[ libfuzzer = libfuzzer ]]
Step #4: ++ /workspace/out/address/libxml2_xml_regexp_compile_fuzzer -runs=4
Step #4: ++ egrep 'Done 4 runs' -c
Step #4: BAD BUILD: the fuzzer seems to have either startup crash or exit.
Step #4: + CHECK_PASSED=0
Step #4: + ((  0 == 0  ))
Step #4: + echo 'BAD BUILD: the fuzzer seems to have either startup crash or exit.'
Step #4: + exit 1
Dor1s added a commit that referenced this issue Sep 6, 2017
…t fixed.

Need to take a closer look at the following issues:
- #815
- #816
- #817
- #818
- #819
- #820
- #821
- #822
- #823
- #824
- #825
- #826
- #827
- #828
- #829
- #830
oliverchang pushed a commit that referenced this issue Sep 7, 2017
…t fixed. (#831)

Need to take a closer look at the following issues:
- #815
- #816
- #817
- #818
- #819
- #820
- #821
- #822
- #823
- #824
- #825
- #826
- #827
- #828
- #829
- #830
@Dor1s
Copy link
Contributor Author

Dor1s commented Sep 8, 2017

That seems a little bit flaky, but sometimes I get the following:

root@c1c55f436d60:/out# ./libxml2_xml_regexp_compile_fuzzer -runs=4 
INFO: Seed: 676310733
INFO: Loaded 1 modules   (41044 guards): 41044 [0xc64db0, 0xc8cf00), 
INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 4096 bytes
INFO: A corpus is not provided, starting from an empty corpus
#2	INITED cov: 170 ft: 166 corp: 1/1b exec/s: 0 rss: 45Mb
#3	NEW    cov: 170 ft: 167 corp: 2/2b exec/s: 0 rss: 45Mb L: 1/1 MS: 1 ShuffleBytes-
#4	NEW    cov: 205 ft: 242 corp: 3/95b exec/s: 0 rss: 45Mb L: 93/93 MS: 2 ShuffleBytes-InsertRepeatedBytes-
#5	DONE   cov: 210 ft: 242 corp: 3/95b exec/s: 0 rss: 45Mb
Done 5 runs in 0 second(s)

@kcc, aren't you surprised? :)

root@c1c55f436d60:/out# for i in `seq 1 100`; do ./libxml2_xml_regexp_compile_fuzzer -runs=4 2>&1 | egrep '[0-9] runs' -o >> log.txt; done
root@c1c55f436d60:/out# cat log.txt | grep 5 -c
16
root@c1c55f436d60:/out# cat log.txt | grep 4 -c
84

@kcc
Copy link
Contributor

kcc commented Sep 8, 2017

Yea, I know.
The problem is that libFuzzer tries to run lsan on some inputs (where malloc/free is unbalanced)
and those runs don't check the value of the -runs flag.
Probably worse fixing just to avoid confusion like yours. Otherwise not an issue.

@Dor1s
Copy link
Contributor Author

Dor1s commented Sep 8, 2017

Thanks for the comment! Would you accept something like https://reviews.llvm.org/D37632?

@kcc
Copy link
Contributor

kcc commented Sep 8, 2017

Yep!

@Dor1s Dor1s self-assigned this Sep 9, 2017
@Dor1s Dor1s closed this as completed Sep 19, 2017
jyknight pushed a commit to jyknight/llvm-monorepo that referenced this issue Sep 28, 2017
…ng a memory leak.

Summary:
Fuzzer::TryDetectingAMemoryLeak may call ExecuteCallback which would
increment TotalNumberOfRuns, but it doesn't respect Options.MaxNumberOfRuns
value specified by a user.

Context: google/oss-fuzz#822 (comment)

Reviewers: kcc

Reviewed By: kcc

Differential Revision: https://reviews.llvm.org/D37632

llvm-svn=312993
Sinoprise pushed a commit to Sinoprise/fuzzer that referenced this issue Aug 15, 2018
…ng a memory leak.

Summary:
Fuzzer::TryDetectingAMemoryLeak may call ExecuteCallback which would
increment TotalNumberOfRuns, but it doesn't respect Options.MaxNumberOfRuns
value specified by a user.

Context: google/oss-fuzz#822 (comment)

Reviewers: kcc

Reviewed By: kcc

Differential Revision: https://reviews.llvm.org/D37632

git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk/lib/fuzzer@312993 91177308-0d34-0410-b5e6-96231b3b80d8
tmatth pushed a commit to tmatth/oss-fuzz that referenced this issue Oct 22, 2018
hyrathon pushed a commit to hyrathon/libfuzzer that referenced this issue Aug 2, 2019
…ng a memory leak.

Summary:
Fuzzer::TryDetectingAMemoryLeak may call ExecuteCallback which would
increment TotalNumberOfRuns, but it doesn't respect Options.MaxNumberOfRuns
value specified by a user.

Context: google/oss-fuzz#822 (comment)

Reviewers: kcc

Reviewed By: kcc

Differential Revision: https://reviews.llvm.org/D37632

git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@312993 91177308-0d34-0410-b5e6-96231b3b80d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants