Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken llvm build #823

Closed
Dor1s opened this issue Sep 6, 2017 · 5 comments
Closed

Broken llvm build #823

Dor1s opened this issue Sep 6, 2017 · 5 comments

Comments

@Dor1s
Copy link
Contributor

Dor1s commented Sep 6, 2017

https://oss-fuzz-build-logs.storage.googleapis.com/index.html

Step #4: ++ sancov -print-coverage-pcs /workspace/out/address/clang-fuzzer
Step #4: ++ wc -l
Step #4: BAD BUILD: the code does not seem to have coverage instrumentation.
Step #4: + local NUMBER_OF_EDGES=0
Step #4: + ((  0 < 90  ))
Step #4: + echo 'BAD BUILD: the code does not seem to have coverage instrumentation.'
Step #4: + CHECK_FAILED=1
Step #4: + ((  1 > 0  ))
Step #4: + exit 1
@kcc
Copy link
Contributor

kcc commented Sep 6, 2017

That's a special case :(
The LLVM build uses fresh llvm and flags that are different from what we currently use in oss-fuzz.
(The new stuff is -fsaintize=fuzzer)

@kcc kcc closed this as completed Sep 6, 2017
@kcc kcc reopened this Sep 6, 2017
@kcc
Copy link
Contributor

kcc commented Sep 6, 2017

Hm. Is this check failing the llvm build now? It shouldn't...

oliverchang pushed a commit that referenced this issue Sep 7, 2017
…t fixed. (#831)

Need to take a closer look at the following issues:
- #815
- #816
- #817
- #818
- #819
- #820
- #821
- #822
- #823
- #824
- #825
- #826
- #827
- #828
- #829
- #830
@Dor1s
Copy link
Contributor Author

Dor1s commented Sep 8, 2017

Just checked the most recent build: https://storage.cloud.google.com/clusterfuzz-builds/llvm/llvm-address-201709080449.zip?_ga=2.98069855.-192946872.1496676137

sancov -print-coverage-pcs doesn't print anything for both clang-fuzzer and llvm-dwarfdump-fuzzer.

Maybe we should wait for the next clang roll on Chromium side. There was a roll today up to https://reviews.llvm.org/rL312679, before that we've been using https://reviews.llvm.org/rL310694 which is one month old...

@kcc
Copy link
Contributor

kcc commented Sep 8, 2017

Yes, see my comment above (special case).
We need
#832 (needs clang roll)
and
https://bugs.llvm.org/show_bug.cgi?id=34314 (needs our work)
to make it work again in oss-fuzz.

@morehouse
Copy link
Contributor

LLVM build has been green for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants