[infra] Enable bad_build_checks without test_all step that runs all the fuzzers. #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverchang
reviewed
Sep 6, 2017
| @@ -41,7 +41,7 @@ for FUZZER_BINARY in $(find $OUT/ -executable -type f); do | |||
| export AFL_NO_UI=1 | |||
| timeout --preserve-status -s INT 20s run_fuzzer $FUZZER | |||
| fi | |||
| bad_build_check $FUZZER_BINARY | |||
|
|
|||
There was a problem hiding this comment.
to prevent all this code duplication, could we just wrap lines 36-43 with another if? we can set an env var (e.g. SKIP_TEST_TARGET_RUN) that controls this in the container builder step.
There was a problem hiding this comment.
Using env var to control that SGTM! Will upload an update, thanks!
|
Done! |
|
Kicked off build of |
|
Looks like we have to revert this again as there are lots of breakages:
Almost all of them seem valid though... |
tmatth
pushed a commit
to tmatth/oss-fuzz
that referenced
this pull request
Oct 22, 2018
…he fuzzers. (google#814) * [infra] Enable bad_build_checks without test_all step that runs all the fuzzers. * [infra] Add COPY step for test_all_for_bad_build script. * [infra] Use SKIP_TEST_TARGET_RUN=1 to avoid running all fuzz targets during test_all. * [infra] Invern the condition in test_all script. * [infra] Finally fix the condition in test_all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to a separate script, I can add an argument to
test_allscript. Something like--bad-build-checks-only.