-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Potentially) broken resiprocate build #826
Comments
Well, this one seems legit. I haven't noticed any issues with instrumentation. However, there is one more target which is even smaller:
I'm not sure that second target makes sense at all... e.g. if I instrument a dummy program like the following one: #include <stddef.h>
#include <stdint.h>
#include <string.h>
extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
int result = 0;
if (size % 2) {
result = strlen((const char*)data);
}
if (size % 4) {
result *= result;
}
for (int i = 0; i < result; ++i) {
result -= i;
}
if (result > 0) return 0;
return 0;
} It gives me 6 edges:
So, the second fuzz target named @gjasny, is there a way to extend those fuzz targets to cover more code paths? |
Hello, the currently activated fuzzing targets in resiprocate just cover the embedded ares library. Those tests are copied / inspired by the c-ares projects fuzz targets. The fuzz-name test could be found here. Extending the ares might be possible, but as a first step, combining the existing ares fuzz targets into one might be feasible. For resiprocate in general I have a PR pending to add a broader coverage across the whole project: resiprocate/resiprocate#82 Thanks, |
Thanks for taking a look! Let's wait for your PR to land. |
resiprocate/resiprocate#82 is merged, but I don't see those new fuzz targets on OSS-Fuzz: https://oss-fuzz.com/v2/fuzzer-stats/by-fuzzer/2018-02-22/2018-02-28/fuzzer/libFuzzer/job/libfuzzer_asan_resiprocate Could you please send a pull request updating https://github.com/google/oss-fuzz/blob/master/projects/resiprocate/build.sh ? The best move would be write it in a such way that it would copy all fuzz targets at once, so you won't need to update it again after adding a new target upstream. Instrumentation numbers are still low for existing fuzz targets, but that's fine. We'll find another way to check instrumentation.
|
I filed #1206 to add the new targets. |
Duplicate of #1331 |
…t fixed. (google#831) Need to take a closer look at the following issues: - google#815 - google#816 - google#817 - google#818 - google#819 - google#820 - google#821 - google#822 - google#823 - google#824 - google#825 - google#826 - google#827 - google#828 - google#829 - google#830
https://oss-fuzz-build-logs.storage.googleapis.com/index.html
89 is so close to the threshold, need to take a closer look whether the target is so small or instrumentation flags are being handled improperly
The text was updated successfully, but these errors were encountered: