Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added primary contact email #11791

Open
wants to merge 59 commits into
base: master
Choose a base branch
from
Open

Added primary contact email #11791

wants to merge 59 commits into from

Conversation

leonate
Copy link

@leonate leonate commented Apr 9, 2024

No description provided.

Copy link

google-cla bot commented Apr 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

github-actions bot commented Apr 9, 2024

leonate is a new contributor to projects/jxls. The PR must be approved by known contributors before it can be merged. The past contributors are: onionpsy

@leonate
Copy link
Author

leonate commented Apr 9, 2024

leonate is a new contributor to projects/jxls. The PR must be approved by known contributors before it can be merged. The past contributors are: onionpsy

@onionpsy could you approve this PR please as you were the original committer of jxls config?

Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am happy to land this given you're a maintainer on the project, which is clear: https://github.com/jxlsteam/jxls/graphs/contributors

@DavidKorczynski
Copy link
Collaborator

@leonate could you take a look at the failed CI, it looks like there are some build issues for the project.

@leonate
Copy link
Author

leonate commented Apr 10, 2024

@leonate could you take a look at the failed CI, it looks like there are some build issues for the project.

Thanks, @DavidKorczynski,
I see it runs Gradle build on CI, which I do not maintain (it was introduced by another contributor and serves as an alternative to the Maven one). How do I switch the CI to run the Maven build instead? Should I modify the build.sh ?

@DavidKorczynski
Copy link
Collaborator

Should I modify the build.sh ?

Yes, please make adjustments to build.sh

@jonathanmetzman
Copy link
Contributor

Ping

@leonate
Copy link
Author

leonate commented May 4, 2024

I made changes to the Dockerfile to install JDK 17 as it is a requirement for Jxls project. Waiting for the checks result..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants