Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade capstone to use python3 #12028

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

twizmwazin
Copy link
Contributor

Upstream has ended python2 support. When removing python2 compatibility code, it was noticed that oss-fuzz was still utilizing this support. This fixes that by moving to a supported version of python3.

See this PR: capstone-engine/capstone#2378

Copy link

google-cla bot commented Jun 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

github-actions bot commented Jun 4, 2024

twizmwazin is a new contributor to projects/capstone. The PR must be approved by known contributors before it can be merged. The past contributors are: kabeor, vanhauser-thc, inferno-chromium, catenacyber, StalkR, devtty1er, Dor1s

@XVilka
Copy link

XVilka commented Jun 6, 2024

twizmwazin is a new contributor to projects/capstone. The PR must be approved by known contributors before it can be merged. The past contributors are: kabeor, vanhauser-thc, inferno-chromium, catenacyber, StalkR, devtty1er, Dor1s

@kabeor could you please take a look?

@maflcko
Copy link
Contributor

maflcko commented Jun 9, 2024

CI failed with: /src/build.sh: ./test_corpus.py: /usr/bin/python: bad interpreter: No such file or directory

@kabeor
Copy link
Contributor

kabeor commented Jun 9, 2024

Hello, we have merged the relevant PR upstream, so we hope to rerun it to apply the patched code, thanks.

@Rot127
Copy link

Rot127 commented Jun 25, 2024

@maflcko Could you please trigger the CI again?

@maflcko
Copy link
Contributor

maflcko commented Jun 25, 2024

I am not a maintainer here. Maybe @DavidKorczynski can help?

@XVilka
Copy link

XVilka commented Jun 26, 2024

@kabeor you probably need to approve it again

@Rot127
Copy link

Rot127 commented Jun 27, 2024

@DavidKorczynski ping

@DavidKorczynski
Copy link
Collaborator

retriggered CI

@DavidKorczynski DavidKorczynski merged commit 9218255 into google:master Jun 27, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants