Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit Apache Arrow for inclusion #3233

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Submit Apache Arrow for inclusion #3233

merged 2 commits into from
Jan 15, 2020

Conversation

pitrou
Copy link
Contributor

@pitrou pitrou commented Jan 15, 2020

Arrow is both an efficient in-memory format for tabular data, an IPC format with zero-copy capabilities, and a set of interoperable language implementations (~10 languages currently: C++, Python, Java, Rust, Go...).

This submission is for fuzzing the Arrow C++ IPC reader. If accepted, we plan to add other fuzz targets, for example for reading Parquet files.

@pitrou
Submit Apache Arrow for inclusion
e29856d 
Arrow is both an efficient in-memory format for tabular data,
an IPC format with zero-copy capabilities, and a set of interoperable
language implementations (~10 languages currently: C++, Python, Java,
Rust, Go...).

This submission is for fuzzing the Arrow C++ IPC reader.
If accepted, we plan to add other fuzz targets, for example for
reading Parquet files.
@pitrou
Copy link
Contributor Author

pitrou commented Jan 15, 2020

cc @wesm, @emkornfield

@pitrou pitrou mentioned this pull request Jan 15, 2020
Merged
3 tasks
@TravisBuddy
Copy link

Travis tests have failed

Hey @pitrou,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 6d3dc3b0-37a4-11ea-b9a4-e90272f6d3fb

@pitrou
Copy link
Contributor Author

pitrou commented Jan 15, 2020

The presubmit script complains weirdly about the primary_contact address...

@TravisBuddy
Copy link

Travis tests have failed

Hey @pitrou,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 39b4f200-37a6-11ea-b9a4-e90272f6d3fb

@fsaintjacques
Copy link

fsaintjacques commented Jan 15, 2020 •
edited
Loading

It expects a list.

@inferno-chromium
Copy link
Collaborator

inferno-chromium commented Jan 15, 2020 •
edited
Loading

Should be fixed in #3234, we added these presubmit rules recently!. Rerunning Travis!

@TravisBuddy
Copy link

Hey @pitrou,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: dea29bd0-37ad-11ea-b9a4-e90272f6d3fb

@emkornfield
Copy link
Contributor

If there are any issues with justifying integration with oss-fuzz, please let me know (happy to discuss here or internally). Google integrates with Apache Arrow across several products so I think this will be valuable, both for Google and Arrow.

Dor1s
Dor1s approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@Dor1s Dor1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Dor1s Dor1s merged commit 648d3f5 into google:master Jan 15, 2020
@pitrou pitrou deleted the submit_arrow branch January 15, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dor1s Dor1s Dor1s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pitrou @TravisBuddy @fsaintjacques @inferno-chromium @emkornfield @Dor1s