Fix bisection when the original checkout is for a single branch. #5478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repos cloned with `--branch BRANCH` will only track that branch, even when we unshallow. If we provide a git SHA from another branch, it will not be recognized. To fix, this, we update the remote tracking config and fetch them. Fixes google/osv.dev#88.
|
PTAL. Only calling this from the bisector for now to be cautious as I'm not sure if this would have unintended consequences elsewhere. |
inferno-chromium
approved these changes
Mar 23, 2021
|
LGTM. What repo was this a problem for? I can test CIFuzz there. |
QT was the one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repos cloned with
--branch BRANCHwill only track that branch, evenwhen we unshallow. If we provide a git SHA from another branch, it will
not be recognized.
To fix, this, we update the remote tracking config and fetch them.
For google/osv.dev#88.