Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving coverage for croniter #9860

Merged

Conversation

sg3-141-592
Copy link
Contributor

fuzz_iter.py

  • Added coverage of optional hash_id parameter
  • Added call to is_valid method
  • Added call to get_next & get_prev methods for the returned croniter iterator

fuzz_match.py

  • Added fuzzing of croniter.match

fuzz_range.py

  • Added fuzzing of croniter.range

@jonathanmetzman
Copy link
Contributor

@DavidKorczynski do you approve?

Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick one for now -- I'll take a bit deeper look shortly

projects/croniter/fuzz_iter.py Outdated Show resolved Hide resolved
projects/croniter/fuzz_iter.py Outdated Show resolved Hide resolved
@sg3-141-592 sg3-141-592 force-pushed the croniter_coverage_improvements branch from 914b931 to 1ca753b Compare March 9, 2023 17:09
@sg3-141-592 sg3-141-592 force-pushed the croniter_coverage_improvements branch 5 times, most recently from 46d815e to 1d54801 Compare March 14, 2023 07:26
projects/croniter/fuzz_match.py Outdated Show resolved Hide resolved
@sg3-141-592 sg3-141-592 force-pushed the croniter_coverage_improvements branch 2 times, most recently from 49b2c8f to 990a8a2 Compare March 14, 2023 17:02
projects/croniter/fuzz_match.py Outdated Show resolved Hide resolved
projects/croniter/fuzz_match.py Outdated Show resolved Hide resolved
projects/croniter/fuzz_range.py Outdated Show resolved Hide resolved
projects/croniter/fuzz_range.py Outdated Show resolved Hide resolved
@sg3-141-592 sg3-141-592 force-pushed the croniter_coverage_improvements branch from 990a8a2 to ce23fc8 Compare March 14, 2023 21:16
@DavidKorczynski DavidKorczynski merged commit 4325da9 into google:master Mar 15, 2023
eamonnmcmanus pushed a commit to eamonnmcmanus/oss-fuzz that referenced this pull request Mar 15, 2023
`fuzz_iter.py`
- Added coverage of optional `hash_id` parameter
- Added call to `is_valid` method
- Added call to `get_next` & `get_prev` methods for the returned
croniter iterator

`fuzz_match.py`
- Added fuzzing of `croniter.match`

`fuzz_range.py`
- Added fuzzing of `croniter.range`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants