Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement initial version of network proxy. #72

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

msuozzo
Copy link
Member

@msuozzo msuozzo commented Jul 24, 2024

No description provided.

@msuozzo msuozzo requested a review from wbxyz July 24, 2024 21:43
Copy link
Member

@wbxyz wbxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a quick glance and discussion offline LGTM. We're submitting as-is to match the existing version developed separately. We'll follow up with a review next week to plan any changes.

@msuozzo
Copy link
Member Author

msuozzo commented Jul 26, 2024

Let's follow up in a bit to work through localizing this code better. Still a lot of work to be done in logging and error-handling. Filed #73 to track

@msuozzo msuozzo merged commit 194db9d into google:main Jul 26, 2024
3 checks passed
@msuozzo msuozzo deleted the push-zvuozsqsxwty branch July 26, 2024 19:58
wbxyz pushed a commit to wbxyz/oss-rebuild that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants