refactor: return nil instead of an empty slice

google · Apr 23, 2024 · e8cc083 · e8cc083
1 parent 8f7feab
commit e8cc083
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 8 deletions.
diff --git a/pkg/lockfile/parse-npm-lock-v1_test.go b/pkg/lockfile/parse-npm-lock-v1_test.go
@@ -188,23 +188,20 @@ func TestParseNpmLock_v1_NestedDependenciesDup(t *testing.T) {
 		Version:   "6.1.0",
 		Ecosystem: lockfile.NpmEcosystem,
 		CompareAs: lockfile.NpmEcosystem,
-		DepGroups: []string{},
 	})
 
 	expectPackage(t, packages, lockfile.PackageDetails{
 		Name:      "supports-color",
 		Version:   "5.5.0",
 		Ecosystem: lockfile.NpmEcosystem,
 		CompareAs: lockfile.NpmEcosystem,
-		DepGroups: []string{},
 	})
 
 	expectPackage(t, packages, lockfile.PackageDetails{
 		Name:      "supports-color",
 		Version:   "2.0.0",
 		Ecosystem: lockfile.NpmEcosystem,
 		CompareAs: lockfile.NpmEcosystem,
-		DepGroups: []string{},
 	})
 }
 
@@ -448,7 +445,6 @@ func TestParseNpmLock_v1_SamePackageDifferentGroups(t *testing.T) {
 			Version:   "5.5.2",
 			Ecosystem: lockfile.NpmEcosystem,
 			CompareAs: lockfile.NpmEcosystem,
-			DepGroups: []string{},
 		},
 	})
 }
diff --git a/pkg/lockfile/parse-npm-lock-v2_test.go b/pkg/lockfile/parse-npm-lock-v2_test.go
@@ -184,14 +184,12 @@ func TestParseNpmLock_v2_NestedDependenciesDup(t *testing.T) {
 			Version:   "6.1.0",
 			Ecosystem: lockfile.NpmEcosystem,
 			CompareAs: lockfile.NpmEcosystem,
-			DepGroups: []string{},
 		},
 		{
 			Name:      "supports-color",
 			Version:   "2.0.0",
 			Ecosystem: lockfile.NpmEcosystem,
 			CompareAs: lockfile.NpmEcosystem,
-			DepGroups: []string{},
 		},
 	})
 }
@@ -440,7 +438,6 @@ func TestParseNpmLock_v2_SamePackageDifferentGroups(t *testing.T) {
 			Version:   "5.5.2",
 			Ecosystem: lockfile.NpmEcosystem,
 			CompareAs: lockfile.NpmEcosystem,
-			DepGroups: []string{},
 		},
 	})
 }
diff --git a/pkg/lockfile/parse-npm-lock.go b/pkg/lockfile/parse-npm-lock.go
@@ -70,7 +70,7 @@ type npmPackageDetailsMap map[string]PackageDetails
 func mergeNpmDepsGroups(a, b PackageDetails) []string {
 	// if either group includes no groups, then the package is in the "production" group
 	if len(a.DepGroups) == 0 || len(b.DepGroups) == 0 {
-		return []string{}
+		return nil
 	}
 
 	combined := make([]string, 0, len(a.DepGroups)+len(b.DepGroups))