Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests against Windows #603

Closed
G-Rath opened this issue Oct 24, 2023 · 0 comments · Fixed by #646
Closed

Run tests against Windows #603

G-Rath opened this issue Oct 24, 2023 · 0 comments · Fixed by #646
Assignees
@G-Rath
Labels
enhancement New feature or request

Comments

@G-Rath
Copy link
Collaborator

G-Rath commented Oct 24, 2023 •
edited
Loading

The test suite should be run against Windows
@G-Rath G-Rath self-assigned this Oct 24, 2023
This was referenced Oct 24, 2023
Closed
Closed
@hogo6002 hogo6002 added the enhancement New feature or request label Oct 27, 2023
@G-Rath G-Rath mentioned this issue Nov 15, 2023
Merged
another-rex pushed a commit that referenced this issue Nov 21, 2023
@G-Rath
ci: run tests on Windows (#646)
521f59c 
Unsurprisingly this has required a bunch of tests to be updated to
handle slightly different variations in file path handling - this
eventually resulted in me implementing an actual internal snapshot
testing package but I've not included that in here since its sizable on
its own; so please keep that in mind when reviewing . (see
https://github.com/G-Rath/osv-scanner/commit/1273da79e2e26a18d663da482dc5f09258e15c51
for a sneakpeek on what the snapshot-based testing looks like)

~Note that is failing because file -> url path translation is actually
busted; I've opened #645 to fix this and you can see the passing CI when
both of these changes are merged in #553~

Resolves #603
Resolves #553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@G-Rath G-Rath

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: run tests on Windows
ci: run tests on Windows
2 participants
@G-Rath @hogo6002