Dependency imports should always be fetched from upstream #1027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two places that we call
mergeParents()
:In
mergeParents()
, we first check ifrelativePath
is defined to know if we can parse parent locally.However, this only applies for the first case but not for importing dependency management.
Also, once we start fetching parent pom.xml from upstream, we should no longer parse locally.
This PR adds
allowLocal
tomergeParents()
to specify if we allow parsing local parent pom.xml, and once a parent is fetched from upstream,allowLocal
is set to false.