Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulnfeeds: Extract commit ranges from other git provider links #243

Closed
westonsteimel opened this issue Oct 15, 2021 · 1 comment · Fixed by #808
Closed

vulnfeeds: Extract commit ranges from other git provider links #243

westonsteimel opened this issue Oct 15, 2021 · 1 comment · Fixed by #808
Assignees
@andrewpollock
Labels
vulnfeeds vulnfeeds

Comments

@westonsteimel
Copy link
Contributor

westonsteimel commented Oct 15, 2021 •
edited
Loading

At least the following from the pypa advisory set:

  • gitlab.com
  • bitbucket.org
@oliverchang oliverchang added the vulnfeeds vulnfeeds label Oct 18, 2021
@westonsteimel westonsteimel changed the title vulnfeeds: Extract commit ranges from GitLab links vulnfeeds: Extract commit ranges from other git provider links Oct 24, 2021
@another-rex another-rex added the actionability tbd Issues where the next steps are unclear label Oct 18, 2022
@oliverchang oliverchang removed the actionability tbd Issues where the next steps are unclear label Nov 1, 2022
@oliverchang
Copy link
Collaborator

This is the relevant code that currently handles parsing of github links to extract the commit hash:

osv.dev/vulnfeeds/cves/versions.go

Line 55 in 85e7db4

func extractGitHubCommit(link string) *FixCommit {

@andrewpollock andrewpollock self-assigned this Nov 7, 2022
andrewpollock added a commit to andrewpollock/osv.dev that referenced this issue Nov 7, 2022
@andrewpollock
Generalise the name of extractGitHubCommit
8a0f534 
To declare google#243 fixed, this will support more than GitHub
andrewpollock added a commit to andrewpollock/osv.dev that referenced this issue Nov 7, 2022
@andrewpollock
Refactor extractGitCommit() and add support for other Git hosts
d9f9566 
* GitLab
* Bitbucket

Fixes: google#243
@andrewpollock andrewpollock mentioned this issue Nov 7, 2022
Merged
andrewpollock added a commit that referenced this issue Nov 11, 2022
@andrewpollock
Add more git repo hosts (#808)
50843c9 
Fixes: #243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewpollock andrewpollock

Labels
vulnfeeds vulnfeeds
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more git repo hosts andrewpollock/osv.dev
4 participants
@oliverchang @westonsteimel @andrewpollock @another-rex