Display the correct introduced event tooltip #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahraaalizadeh
commented
Jun 25, 2024
Comment on lines
235
to
237
| <span class="tooltiptext">Unknown commit / All previous commits are affected</span> | ||
| {% else -%} | ||
| <span class="tooltiptext">Unknown version / All previous versions are affected</span> |
There was a problem hiding this comment.
I slightly updated the suggested text for the tooltip to get it fit a single line. With long messages the introduced and fixed rows will be one line apart:
zahraaalizadeh
changed the title
|
I think it's important to have the "introduced" in there, can we change the max-width in the css to make it fit on one line? |
another-rex
reviewed
Jun 27, 2024
| @@ -219,24 +219,26 @@ <h3 class="mdc-layout-grid__cell--span-3"> | |||
| <dd> | |||
| <div class="mdc-layout-grid__inner events"> | |||
| {% for event in range.events -%} | |||
| <div class="mdc-layout-grid__cell--span-3"> | |||
| <div class="mdc-layout-grid__cell--span-2"> | |||
There was a problem hiding this comment.
Are the layout width changes intentional? I do prefer to keep the width the same here if possible.
There was a problem hiding this comment.
@another-rex Ah, yesterday, I had an afternoon brain and tried a few options, but none worked. Just re-tried and now it's been fixed.
zahraaalizadeh
force-pushed
the
issue-2336/affected-range-tooltip-text
branch
from
5b9c8d4
to
3a33842
Compare
another-rex
approved these changes
Jun 27, 2024
|
Thanks! I think just merging in the main branch should fix the PR check. |
Prior to this change, when the introduced version in the affected range was 0, the tooltip displayed: "The exact introduced commit is unknown". This change, updates the html block to be more readable, and displays a more descriptive tooltip based on the type of the range, indicating if it has versions or commits.
zahraaalizadeh
force-pushed
the
issue-2336/affected-range-tooltip-text
branch
from
3a33842
to
d713932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, when the introduced version in the affected range was 0, the tooltip displayed: "The exact introduced commit is unknown".
This change, updates the html block to be more readable, and displays a more descriptive tooltip based on the type of the range, indicating if it has versions or commits.
resolves: #2336
Sample output for GIT range:
Sample output for other type of ranges:
