Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make value change handling for experiment creation more lightweight #28

Closed
priyald17 opened this issue Jul 24, 2013 · 1 comment
Closed

Comments

@priyald17
Copy link
Contributor

Currently, each text box and check box in experiment creation has its own anonymous value change handler. This could become a performance issue once there are multiple input groups. So, for classes with multiple ValueChangeHandlers (e.g. InputsPanel), let the containing class be the ValueChangeHandler.

@ghost ghost assigned priyald17 Jul 24, 2013
@priyald17
Copy link
Contributor Author

Upon re-evaluation, it seems that this isn't that big a gain in speed because ValueChangeHandler and ValueChangeHandler calls need to be handled either separately or with a lot of casting. For now, will leave value change handling for inputs as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant