Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: derive PartialEq for enum Error #71

Closed
whitevegagabriel opened this issue Sep 28, 2023 · 1 comment · Fixed by #72
Closed

Feature request: derive PartialEq for enum Error #71

whitevegagabriel opened this issue Sep 28, 2023 · 1 comment · Fixed by #72

Comments

@whitevegagabriel
Copy link

As part of my implementation, I define a custom Error, one variant which wraps an Error enum that is generated by PDL.

In some of my tests, I check that I get the expected error types, which is simplified if I derive PartialEq for my Error enum.

Problem is, I have to implement PartialEq for the PDL-generated Error enum if I want one of my error variants to wrap it.

Is it feasible to derive PartialEq for Error enums?

@whitevegagabriel
Copy link
Author

Another note:
I am happy to create a PR to implement this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant