Compiler warnings when building perf_data_converter

[aalexand]

$ bazel build src:perf_to_profile
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: SHA256 (https://github.com/google/boringssl/archive/master-with-bazel.zip) = cec1a5180dc44d083573015694a5cc40a194920a1e7665dc005592a08d959597
DEBUG: Rule 'boringssl' indicated that a canonical reproducible form can be obtained by modifying arguments sha256 = "cec1a5180dc44d083573015694a5cc40a194920a1e7665dc005592a08d959597"
DEBUG: Call stack for the definition of repository 'boringssl' which is a http_archive (rule definition at /usr/local/google/home/aalexand/.cache/bazel/_bazel_aalexand/f6d7d2335bdf63a7813e232f542cf0f2/external/bazel_tools/tools/build_defs/repo/http.bzl:262:16):
 - /usr/local/google/home/aalexand/src/perf_data_converter/WORKSPACE:27:1
INFO: Analyzed target //src:perf_to_profile (19 packages loaded, 1079 targets configured).
INFO: Found 1 target...
INFO: From Compiling src/quipper/perf_reader.cc:
src/quipper/perf_reader.cc: In member function 'bool quipper::PerfReader::ReadCPUTopologyMetadata(quipper::DataReader*, size_t)':
src/quipper/perf_reader.cc:1525:23: warning: comparison of integer expressions of different signedness: 'int' and 'uint32_t' {aka 'unsigned int'} [-Wsign-compare]
     for (int i = 0; i < nrcpus; ++i) {
                     ~~^~~~~~~~
INFO: From Compiling src/perf_data_converter.cc:
src/perf_data_converter.cc: In member function 'perftools::ProcessProfiles perftools::{anonymous}::PerfDataConverter::Profiles()':
src/perf_data_converter.cc:663:21: warning: comparison of integer expressions of different signedness: 'int' and 'std::deque<perftools::profiles::Builder>::size_type' {aka 'long unsigned int'} [-Wsign-compare]
   for (int i = 0; i < builders_.size(); i++) {
                   ~~^~~~~~~~~~~~~~~~~~
INFO: From Compiling src/quipper/perf_serializer.cc:
src/quipper/perf_serializer.cc: In member function 'bool quipper::PerfSerializer::DeserializeAuxtraceInfoEvent(const quipper::PerfDataProto_AuxtraceInfoEvent&, quipper::event_t*) const':
src/quipper/perf_serializer.cc:1006:21: warning: comparison of integer expressions of different signedness: 'quipper::u64' {aka 'long unsigned int'} and 'int' [-Wsign-compare]
   for (u64 i = 0; i < sample.unparsed_binary_blob_priv_data_size(); ++i) {
                   ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/quipper/perf_serializer.cc: In member function 'const quipper::SampleInfoReader* quipper::PerfSerializer::GetSampleInfoReaderForEvent(const event_t&) const':
src/quipper/perf_serializer.cc:1467:24: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'ssize_t' {aka 'long int'} [-Wsign-compare]
         if (array_size <= event_id_pos) {
             ~~~~~~~~~~~^~~~~~~~~~~~~~~
src/quipper/perf_serializer.cc:1482:24: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'ssize_t' {aka 'long int'} [-Wsign-compare]
         if (array_size < event_id_pos) {
             ~~~~~~~~~~~^~~~~~~~~~~~~~
Target //src:perf_to_profile up-to-date:
  bazel-bin/src/perf_to_profile
INFO: Elapsed time: 60.432s, Critical Path: 17.10s
INFO: 560 processes: 560 linux-sandbox.
INFO: Build completed successfully, 567 total actions

[ZachMarcus]

Fixed by 1684499