Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Instructions for Perforce SSO using Google Identity and OIDC #1

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Conversation

davidair
Copy link
Contributor

No description provided.

google_sso/README.md Outdated Show resolved Hide resolved
google_sso/README.md Outdated Show resolved Hide resolved
google_sso/README.md Outdated Show resolved Hide resolved
google_sso/README.md Outdated Show resolved Hide resolved
Copy link

@noahdungey noahdungey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits.

@davidair
Copy link
Contributor Author

Addressed all the comments.

Copy link

@noahdungey noahdungey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I would prefer that the two firewall rules be set by network tag and then both "helix" and "has" tags be added to your instance. That can be left for a future change.

@davidair davidair merged commit 231e216 into master Feb 19, 2021
@davidair davidair deleted the sso branch February 19, 2021 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants