Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Larger space units needed #137

Closed
ahh opened this issue Apr 27, 2017 · 0 comments · Fixed by #138
Closed

Larger space units needed #137

ahh opened this issue Apr 27, 2017 · 0 comments · Fixed by #138

Comments

@ahh
Copy link
Contributor

ahh commented Apr 27, 2017

Currently pprof tops out at GB (Well, GiB: #136 :P). I have profiles containing quantities much larger than 2^30 bytes.

Please add TiB and PiB.
aalexand added a commit to aalexand/pprof that referenced this issue Apr 30, 2017
@aalexand
Add support for terabyte and petabyte memory units.
2c39f0d 
This fixes google#137 (but not google#136, this will come separately once we decide
what we want to do if anything).
@aalexand aalexand mentioned this issue Apr 30, 2017
Merged
rauls5382 pushed a commit that referenced this issue May 1, 2017
@aalexand @rauls5382
Add support for terabyte and petabyte memory units. (#138)
c0fb62e 
* Add support for terabyte and petabyte memory units.

This fixes #137 (but not #136, this will come separately once we decide
what we want to do if anything).

* Add a test.

* Update copyright year
gmarin13 pushed a commit to gmarin13/pprof that referenced this issue Dec 17, 2020
@aalexand
Add support for terabyte and petabyte memory units. (google#138)
163e971 
* Add support for terabyte and petabyte memory units.

This fixes google#137 (but not google#136, this will come separately once we decide
what we want to do if anything).

* Add a test.

* Update copyright year
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for terabyte and petabyte memory units. aalexand/pprof
1 participant
@ahh