Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Action badge and remove duplicated CI. #547

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Conversation

wyk9787
Copy link
Contributor

@wyk9787 wyk9787 commented Jun 26, 2020

Fixes #540

10.3 is the oldest supported Xcode version. Support for any previous versions of Xcode is dropped. macOS 10.15 is the only supported macOS version now.

  • Added Github Action badge.

  • Removed AppVeyor and its badge.

  • Removed most of the Travis CI script with the exception of Golang master version.

References of macOS and Xcode support:

@wyk9787
Copy link
Contributor Author

wyk9787 commented Jun 26, 2020

The previous PR's Github Action passed: https://github.com/google/pprof/actions/runs/148062605.

Github Action's script takes effect as expected in this PR. It also includes the version (i.e. a few more XCode versions) that I added in this PR.

@aalexand Could you remove AppVeyor as required check for PR submission in the setting?

@kalyanac
Copy link
Contributor

Could you remove AppVeyor as required check for PR submission in the setting?

Disabled AppVeyor webhook.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2020

Codecov Report

Merging #547 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
+ Coverage   68.38%   68.41%   +0.03%     
==========================================
  Files          78       78              
  Lines       16088    16088              
==========================================
+ Hits        11001    11006       +5     
+ Misses       4228     4226       -2     
+ Partials      859      856       -3     
Impacted Files Coverage Δ
internal/binutils/binutils.go 60.86% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eab82f0...18865f6. Read the comment docs.

@wyk9787
Copy link
Contributor Author

wyk9787 commented Jun 29, 2020

Could you remove AppVeyor as required check for PR submission in the setting?

Disabled AppVeyor webhook.

Thanks! Checks are now passing.

@kalyanac
Copy link
Contributor

Can you mention in the description what is the oldest XCode and OSX versions this will support and what versions are getting dropped?

@wyk9787
Copy link
Contributor Author

wyk9787 commented Jun 29, 2020

Can you mention in the description what is the oldest XCode and OSX versions this will support and what versions are getting dropped?

Done.

@kalyanac kalyanac merged commit f08ab7d into google:master Jun 29, 2020
@@ -1,5 +1,5 @@
![](https://github.com/google/pprof/workflows/ci/badge.svg)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The badge links to the image itself which is not useful and is uncommon to do. Please make the badge link to the CI status page, like the AppVeyor badge did and like Travis CI and Codecov badges do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent #549.

giordano added a commit to JuliaPackaging/Yggdrasil that referenced this pull request Nov 13, 2020
* Update pprof to latest revision

Bump from 20191205061153 => 20201109224723

My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`)

Includes:
- google/pprof#564
- google/pprof#575
- google/pprof#574
- google/pprof#571
- google/pprof#572
- google/pprof#570
- google/pprof#562
- google/pprof#561
- google/pprof#565
- google/pprof#560
- google/pprof#563
- google/pprof#557
- google/pprof#554
- google/pprof#552
- google/pprof#545
- google/pprof#549
- google/pprof#547
- google/pprof#541
- google/pprof#534
- google/pprof#542
- google/pprof#535
- google/pprof#531
- google/pprof#530
- google/pprof#528
- google/pprof#522
- google/pprof#525
- google/pprof#527
- google/pprof#519
- google/pprof#520
- google/pprof#517
- google/pprof#518
- google/pprof#514
- google/pprof#513
- google/pprof#510
- google/pprof#508
- google/pprof#506
- google/pprof#509
- google/pprof#504

* Update P/pprof/build_tarballs.jl - use a real version number

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

* Remove now unused `timestamp`

* [pprof] Use `GitSource`

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
gmarin13 pushed a commit to gmarin13/pprof that referenced this pull request Dec 17, 2020
* Add Github Action badge and remove duplicated ci

* Remove comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIgrate CI tests to use GitHub Actions
5 participants