-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github Action badge and remove duplicated CI. #547
Conversation
The previous PR's Github Action passed: https://github.com/google/pprof/actions/runs/148062605. Github Action's script takes effect as expected in this PR. It also includes the version (i.e. a few more XCode versions) that I added in this PR. @aalexand Could you remove AppVeyor as required check for PR submission in the setting? |
Disabled AppVeyor webhook. |
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
==========================================
+ Coverage 68.38% 68.41% +0.03%
==========================================
Files 78 78
Lines 16088 16088
==========================================
+ Hits 11001 11006 +5
+ Misses 4228 4226 -2
+ Partials 859 856 -3
Continue to review full report at Codecov.
|
Thanks! Checks are now passing. |
Can you mention in the description what is the oldest XCode and OSX versions this will support and what versions are getting dropped? |
Done. |
@@ -1,5 +1,5 @@ | |||
![](https://github.com/google/pprof/workflows/ci/badge.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The badge links to the image itself which is not useful and is uncommon to do. Please make the badge link to the CI status page, like the AppVeyor badge did and like Travis CI and Codecov badges do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sent #549.
Bump from 20191205061153 => 20201109224723 My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`) Includes: - google/pprof#564 - google/pprof#575 - google/pprof#574 - google/pprof#571 - google/pprof#572 - google/pprof#570 - google/pprof#562 - google/pprof#561 - google/pprof#565 - google/pprof#560 - google/pprof#563 - google/pprof#557 - google/pprof#554 - google/pprof#552 - google/pprof#545 - google/pprof#549 - google/pprof#547 - google/pprof#541 - google/pprof#534 - google/pprof#542 - google/pprof#535 - google/pprof#531 - google/pprof#530 - google/pprof#528 - google/pprof#522 - google/pprof#525 - google/pprof#527 - google/pprof#519 - google/pprof#520 - google/pprof#517 - google/pprof#518 - google/pprof#514 - google/pprof#513 - google/pprof#510 - google/pprof#508 - google/pprof#506 - google/pprof#509 - google/pprof#504
* Update pprof to latest revision Bump from 20191205061153 => 20201109224723 My personal interest is to pull in google/pprof#564, which adds support for displaying names with `"` in them, which julia functions sometimes have (e.g. `var"#foo#23"`) Includes: - google/pprof#564 - google/pprof#575 - google/pprof#574 - google/pprof#571 - google/pprof#572 - google/pprof#570 - google/pprof#562 - google/pprof#561 - google/pprof#565 - google/pprof#560 - google/pprof#563 - google/pprof#557 - google/pprof#554 - google/pprof#552 - google/pprof#545 - google/pprof#549 - google/pprof#547 - google/pprof#541 - google/pprof#534 - google/pprof#542 - google/pprof#535 - google/pprof#531 - google/pprof#530 - google/pprof#528 - google/pprof#522 - google/pprof#525 - google/pprof#527 - google/pprof#519 - google/pprof#520 - google/pprof#517 - google/pprof#518 - google/pprof#514 - google/pprof#513 - google/pprof#510 - google/pprof#508 - google/pprof#506 - google/pprof#509 - google/pprof#504 * Update P/pprof/build_tarballs.jl - use a real version number Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com> * Remove now unused `timestamp` * [pprof] Use `GitSource` Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
* Add Github Action badge and remove duplicated ci * Remove comments
Fixes #540
10.3 is the oldest supported Xcode version. Support for any previous versions of Xcode is dropped. macOS 10.15 is the only supported macOS version now.
Added Github Action badge.
Removed AppVeyor and its badge.
Removed most of the Travis CI script with the exception of Golang master version.
References of macOS and Xcode support:
Github Action currently only supports macOS 10.15.
Github Action's Xcode support: https://github.com/actions/virtual-environments/blob/master/images/macos/macos-10.15-Readme.md#xcode
Travis CI's macOS & Xcode support: https://docs.travis-ci.com/user/reference/osx/#macos-version