Allow binary override for profiles with no mappings #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks good. Can you add a comment in the source code about this specificity of profiles generated by Go runtime? As a more general question: these profiles won't symbolize for any shared objects or if the executable is PIC & ASLR'ed? |
The go runtime generates profiles in profile.proto format without symbols or mappings. The expectation is that these can be symbolized by passing the binary name to pprof. The mechanism pprof uses relies to override the binary relies on there being a mapping, and previously we moved the creation of fake mappings to the legacy profile handlers, so profiles parsed from profile.proto with no mappings can no longer be symbolized. Special case this situation to create a fake mapping and associate all locations to it if there is a command line override but no mappings.
rauls5382
force-pushed
the
nomappings
branch
from
497ea7a
to
c5e4c68
Compare
|
That's correct, symbolization with a fake mapping is only possible with a non-ASLR binary. |
aalexand
approved these changes
Feb 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go runtime generates profiles in profile.proto format
without symbols or mappings. The expectation is that these
can be symbolized by passing the binary name to pprof.
The mechanism pprof uses relies to override the binary relies
on there being a mapping, and previously we moved the creation
of fake mappings to the legacy profile handlers, so profiles
parsed from profile.proto with no mappings can no longer be
symbolized.
Special case this situation to create a fake mapping and associate
all locations to it if there is a command line override but no
mappings.