Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] emit cmake packages to the arch-specific directory? #11

Closed
DanAlbert opened this issue Nov 6, 2019 · 0 comments · Fixed by #23
Closed

[FR] emit cmake packages to the arch-specific directory? #11

DanAlbert opened this issue Nov 6, 2019 · 0 comments · Fixed by #23
Labels
enhancement New feature or request
Milestone
1.0

Comments

@DanAlbert
Copy link
Member

We currently emit the config file directly to the output directory. CMake's docs indicate that it will look in other places as well (https://cmake.org/cmake/help/latest/command/find_package.html#search-procedure), one of which is architecture specific which would make it easier to share the output directory among multi-arch builds.

I'd tried this first, but CMake didn't appear to be searching those other directories. Should spend some more time trying to figure out why.
@DanAlbert DanAlbert added the enhancement New feature or request label Nov 6, 2019
@DanAlbert DanAlbert added this to the 1.0 milestone Nov 6, 2019
DanAlbert added a commit to DanAlbert/prefab that referenced this issue Nov 9, 2019
@DanAlbert
Use the architecture-specific layout for CMake.
b9a7363 
We can't do this in every case, since old NDKs didn't set the
appropriate value in their toolchain file, but use it where we can.

Fixes google#11
@DanAlbert DanAlbert mentioned this issue Nov 9, 2019
Merged
DanAlbert added a commit that referenced this issue Nov 11, 2019
@DanAlbert
Use the architecture-specific layout for CMake.
0f612a0 
We can't do this in every case, since old NDKs didn't set the
appropriate value in their toolchain file, but use it where we can.

Fixes #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Use the architecture-specific layout for CMake. DanAlbert/prefab
1 participant
@DanAlbert