Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] direct handling of maven coordinates for non-AGP Android workflows? #150

Open
DanAlbert opened this issue Feb 10, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@DanAlbert
Copy link
Member

We could eliminate a few steps in https://google.github.io/prefab/example-workflow if prefab accepted maven coordinates as well as file paths. That doc is deceptively simple because it uses an AAR that has no other dependencies. The user needs to fetch and handle all their transitive dependencies, and it's not realistic to expect arbitrary build systems that integrate prefab to include support for fetching maven packages. Prefab could instead do that. Presumably it wouldn't be too difficult since it's implemented in Kotlin so has easy access to the maven API.

Perhaps prefab is the wrong place to do this though, and it would be better to create a second tool to do this. Handling of maven and AARs is fairly Android specific, and the work isn't really related to the rest of what prefab does. Plus, we'd end up with dependencies on SSL and HTTP libraries and it'd be much better to keep potential CVEs out of prefab since AGP uses a fixed default version of prefab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant