Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove frozenMessageModificationHandler #175

Closed
sigurdm opened this issue Jan 8, 2019 · 0 comments · Fixed by #643
Closed

Remove frozenMessageModificationHandler #175

sigurdm opened this issue Jan 8, 2019 · 0 comments · Fixed by #643

Comments

@sigurdm
Copy link
Collaborator

sigurdm commented Jan 8, 2019

Currently we have frozenMessageModificationHandler that is used to throw when a frozen message is changed. It can be customized.

FrozenPbList and a frozen PbMap do not use this, but will just throw.
This is inconsistent. And it is not clear to me how much is gained by the hook.

I suggest we remove the handler from the public API, and always just throw.
osa1 added a commit to osa1/protobuf.dart that referenced this issue May 9, 2022
@osa1
Remove frozen message modification handling
b6f6ebd 
See google#175 for the problems with this API.

Internally this API is not used. However this is still a breaking change
and will be released with the next major release.

Fixes google#175
osa1 added a commit to osa1/protobuf.dart that referenced this issue May 9, 2022
@osa1
Remove frozen message modification handling
3c3cc60 
See google#175 for the problems with this API.

Internally this API is not used. However this is still a breaking change
and will be released with the next major release.

Fixes google#175
@osa1 osa1 mentioned this issue May 9, 2022
Merged
osa1 added a commit to osa1/protobuf.dart that referenced this issue May 9, 2022
@osa1
Remove frozen message modification handling
a321d8f 
See google#175 for the problems with this API.

Internally this API is not used. However this is still a breaking change
and will be released with the next major release.

Fixes google#175
@osa1 osa1 closed this as completed in #643 Jun 15, 2022
osa1 added a commit that referenced this issue Jun 15, 2022
@osa1
Remove frozen message modification handling (#643)
598deb9 
See #175 for the problems with this API.

Fixes #175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove frozen message modification handling osa1/protobuf.dart
1 participant
@sigurdm