Remove event mixin stuff #738
Comments
osa1
added a commit
to osa1/protobuf.dart
that referenced
this issue
Oct 10, 2023
This removes `PbEventMixin`, `PbFieldChange`, and `EventBuffer` types, and the event plugin mixin support from the plugin. This mixin is currently not used internally and we don't want to introduce uses to it to keep the API surface small, to make it easier to make changes or migrate to another protobuf library. Fixes google#738. cl/571893384
Merged
osa1
added a commit
that referenced
this issue
Oct 12, 2023
Event support is currently unused internally and we don't want to introduce new uses of it, to keep the API surface small and the library easier to update, and to make it easier to migrate to another library. `createRepeatedField` and `createMapField` existed to support events (as `PbList` and `PbMap` don't support this), so with the event mixin removed we remove these members as well. Removing these members give us other opportunities: we now have full control over the field value types. This allows, for example, refactoring `PbMap` and `PbList` types for marking them as frozen without visiting the elements, which makes it possible to implement decoders that create frozen objects without having to make another pass after decoding to mark every object as frozen. Closes #738. cl/571893384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PbEventMixin,PbFieldChange, andEventBufferare currently unused. No need to maintain unused code, we should just remove them.They're just a few lines of code and implemented as a separate library (instead of as a part of the protobuf library), so users can implement that stuff themselves if needed.
The text was updated successfully, but these errors were encountered: