Remove a closure in _FieldSet.hashCode
#633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves HashCode benchmark up to 3%.
JIT before:
HashCode(RunTime): 1981.9821782178217 us.
HashCode(RunTime): 1974.7068114511353 us.
HashCode(RunTime): 1970.9261083743843 us.
JIT after:
HashCode(RunTime): 1899.034155597723 us.
HashCode(RunTime): 1912.0917782026768 us.
HashCode(RunTime): 1908.1782650142993 us.
Native AOT before:
HashCode(RunTime): 5164.038659793814 us.
HashCode(RunTime): 5177.984496124031 us.
HashCode(RunTime): 5192.199481865285 us.
Native AOT after:
HashCode(RunTime): 5027.246231155779 us.
HashCode(RunTime): 5045.488664987405 us.
HashCode(RunTime): 5134.379487179487 us.
JS before:
HashCode(RunTime): 6944.444444444444 us.
HashCode(RunTime): 6913.793103448276 us.
HashCode(RunTime): 6927.335640138408 us.
JS after:
HashCode(RunTime): 6846.41638225256 us.
HashCode(RunTime): 6965.277777777777 us.
HashCode(RunTime): 6920.415224913495 us.
Fixes google#632
rakudrama
reviewed
Apr 25, 2022
|
Ported to internal in cl/449694660. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves HashCode benchmark up to 3%.
JIT before:
JIT after:
Native AOT before:
Native AOT after:
JS before:
JS after:
Fixes #632