Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check message mutability in merge/deserialize methods #727

Merged
merged 6 commits into from
Sep 7, 2022
Merged

Check message mutability in merge/deserialize methods #727

merged 6 commits into from
Sep 7, 2022

Conversation

osa1
Copy link
Member

@osa1 osa1 commented Aug 9, 2022 •
edited
Loading

Fixes #489

cl/472654122

@osa1 osa1 requested a review from sigurdm August 9, 2022 10:00
@osa1
Copy link
Member Author

osa1 commented Aug 11, 2022

This is tested in cl/466894451, which unfortunately reports some breakage...

@osa1
Copy link
Member Author

osa1 commented Sep 5, 2022 •
edited
Loading

One user fixed, two more to go... Two users fixed, one more to go.

@osa1
Copy link
Member Author

osa1 commented Sep 7, 2022

Users fixed, merging.

@osa1 osa1 merged commit f246fd6 into google:master Sep 7, 2022
@osa1 osa1 deleted the fix_489 branch September 7, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.freeze() still allows modifications, from e.g. .mergeFromProto3Json()
2 participants
@osa1 @sigurdm