-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest lints and Dart SDK #828
Conversation
@mraleph ? |
I will let @osa1 review once he has cycles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes LGTM, but I'm not sure if the changes in coded_buffer_writer
are safe (added an inline comment).
Secondly, we should land #816 first or opt-out from internal lints in the internal version (which I think makes sense given the package is third-party) and revert the CLs listed in #816.
I have no cycles to keep these two versions in sync and this kind of style changes (either in the internal version or open source) only make it difficult for actual users to make changes. For example #825 is for an internal user and we have to do those changes manually in the internal version to be able to test and actually use it. #790 is another example of a useful change.
@osa1 – now ready for your review! |
@osa1 – PTAL |
No description provided.