Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google sync #607

Merged
merged 42 commits into from
Jun 23, 2020
Merged

Google sync #607

merged 42 commits into from
Jun 23, 2020

Conversation

rchen152
Copy link
Contributor

No description provided.

martindemello and others added 30 commits June 23, 2020 14:13
@martindemello @rchen152
Do not check container type mutations if there are multiple bindings …
fa17f20 
…to self.

This fixes false positives when we mutate a container with multiple annotated
types, e.g.

  def foo(l1: List[int], l2: List[str], b):
    if b:
      x = l1
      y = 3
    else:
      x = l2
      y = "foo"
    x.append(y)

PiperOrigin-RevId: 316177667
@rchen152
Make a couple of quick fixes to --check-container-types.
83b620f 
I was playing around with this new feature and noticed a couple of bugs:
* An element type that is annotated as Any should stay as Any.
* from_annotation needed to be set in a couple of additional places.

PiperOrigin-RevId: 316208219
@Solumin @rchen152
Resolve TODO by moving test higher in the file.
dc08be9 
PiperOrigin-RevId: 316502772
@Solumin @rchen152
Change TODO(kramm) to TODO(bug).
52fa28d 
PiperOrigin-RevId: 316504732
@Solumin @rchen152
Change TODO(kramm) to TODO(bug)
89cba91 
PiperOrigin-RevId: 316507034
@Solumin @rchen152
Update TODO related to _methodname in csv output.
d6d090b 
PiperOrigin-RevId: 316508846
@Solumin @rchen152
Add bug for investigating MAX_DEPTH.
0b66aca 
See b/159041279 for a bit more about this.

PiperOrigin-RevId: 316514137
@martindemello @rchen152
Add a test for special_builtins.Next
4ef9c82 
PiperOrigin-RevId: 316514740
@rchen152
Scrub TODOs in vm.py.
f17636f 
* Removes obsolete and not directly actionable TODOs.
* Resolves a TODO for memoizing a method.
* Converts other TODOs from TODO(person) to TODO(bug).

PiperOrigin-RevId: 316515198
@Solumin @rchen152
Remove unneeded TODO.
bafa333 
There's no need to raise an error here.

PiperOrigin-RevId: 316515728
@rchen152
Scrub TODOs in function.py.
b38a4fa 
* Adds a bug for one TODO.
* Removes another and leaves an informational comment instead.

PiperOrigin-RevId: 316518934
@martindemello @rchen152
Clean up some old TODOs
9c2120f 
Removed several TODOs as being obsolete, or overly complicated for the
benefit they would provide.

Converted some TODOs to bugs or comments in the code:
- matcher.py
- CMakeLists.txt
- mixin.py

PiperOrigin-RevId: 316526842
@rchen152
Remove old TODOs in analyze.py.
08afafe 
* Implementing the node TODO led to failing tests, so I removed it.
* I couldn't figure out what "Record these:" meant.
* Removed the TODO for aliases and instead documented how they're handled.

PiperOrigin-RevId: 316528462
@rchen152
Remove an old TODO in load_pytd.
2357128 
PiperOrigin-RevId: 316530837
@Solumin @rchen152
Update TODO about better testing.
4d1f8f5 
Also fixes a linter error.

PiperOrigin-RevId: 316533249
@Solumin @rchen152
Clean up TODOs.
57f7b9e 
PiperOrigin-RevId: 316535617
@rchen152
Change TODO(kramm) to TODO(bug) in output.py.
334ffbe 
PiperOrigin-RevId: 316537199
@Solumin @rchen152
Map all TODOs to a bug.
ed6e9aa 
These are by-and-large small cleanups, so a single bug suffices.

PiperOrigin-RevId: 316539007
@Solumin @rchen152
Remove stale TODOs.
dad045e 
PiperOrigin-RevId: 316547125
@rchen152
Remove old TODOs in convert.py.
8b43991 
PiperOrigin-RevId: 316547257
@Solumin @rchen152
Clean up TODOs
687c661 
PiperOrigin-RevId: 316549161
@rchen152
Remove old TODO.
fade7ee 
"pivot" seems like a reasonable name to me.

PiperOrigin-RevId: 316557183
@martindemello @rchen152
Clean up old TODOs in abstract.py
3a0ea94 
PiperOrigin-RevId: 316559066
@Solumin @rchen152
Remove obsolete TODOs.
d66ada5 
PiperOrigin-RevId: 316561475
@rchen152
Resolve TODOs in pytype/pyi/.
9c7725b 
I resolved a TODO to keep only one copy of pytd/typeshed_test and
pyi/parse_typeshed_test by deleting the latter. Based on the file history,
pytd/typeshed_test is the one that is actively maintained.

I removed all the other TODOs as likely not worth doing, especially since we
want to eventually replace this parser.

PiperOrigin-RevId: 316565341
@Solumin @rchen152
Add a bug for a TODO.
7f7e314 
PiperOrigin-RevId: 316565368
@rchen152
Clean up TODOs in visitors.py
228095b 
PiperOrigin-RevId: 316578011
@Solumin @rchen152
Clean up TODOs in typegraph code.
02f36ea 
PiperOrigin-RevId: 316578057
@martindemello @rchen152
Convert some tests/* TODOs into bugs
93220f0 
Also added two relatively complex examples under bugs/ and suppressed the warning for the unused "dep" import because it's annoying to have to remember to readd it every time i want to test a bug with a dependency.

PiperOrigin-RevId: 316593129
@Solumin @rchen152
Add Python 3 test for vararg annotations.
64430c2 
PiperOrigin-RevId: 316729481
Solumin and others added 12 commits June 23, 2020 14:54
@Solumin @rchen152
Change TODOs to point to bug.
9d943a7 
PiperOrigin-RevId: 316742617
@martindemello @rchen152
Clean up TODOs in tests.
cfb0f73 
PiperOrigin-RevId: 316751830
@rchen152
Finish implementation of --check-attribute-types.
c99fe8b 
* Makes the annotation always take precedence over any inferred type in stubs.
* Stores annotations that are declared on instance attributes. This allows
  type-checking against annotations declared in __init__ or __new__.

PiperOrigin-RevId: 316777060
@rchen152
Dedup type annotations using their opcodes.
e43c0c1 
PiperOrigin-RevId: 317002471
@martindemello @rchen152
Display the type of dataclass FieldInstance correctly.
91d274c 
PiperOrigin-RevId: 317018641
@superbobry @rchen152
First step towards better import support in xref
350d2d7 
Imported names now only create a binding if they are aliased. The alias has
subkind import and is connected to imported name (not its definition!) via
*aliases* edge. The imported name is connected to the corresponding definition
via *ref/imports* edge.

See testdata/imports.py for an example.

Note that from-imports are currently restricted to submodules, importing
anything else e.g.

  from sys import version

does not produce a ref.

Another limitation has to do with subpackages, both

  import foo.bar.boo

and

  from foo.bar import boo

do not produce refs for neither foo nor foo.bar.

PiperOrigin-RevId: 317156912
@superbobry @rchen152
Allowed from-importing symbols other than modules
7c6b3e2 
For example

  from sys import path

will now correctly reference sys.path.

PiperOrigin-RevId: 317157234
@rchen152
Type-check parameter defaults against annotations.
c03b1c6 
For now, this feature is hidden behind yet another flag,
--check-parameter-types.

I also did a bit of cleanup: removed an unnecessary lint version directive and
extraneous arguments to a super() call, fixed a method signature so it matched
the superclass signature, and changed a check for the existence of annotations
to a more precise check for the existence of parameter annotations.

PiperOrigin-RevId: 317216325
@rchen152
Type-check assignments to annotated function parameter names.
5e4f3cd 
This is a little different from what b/113372317 asks for but in the same
spirit: if you don't allow `def f(x: int = 0.0): ...`, why would you allow
`def f(x: int): x = 0.0`? Plus, now that we're enforcing annotations strictly
everywhere else, it would be confusing to be lenient here.
PiperOrigin-RevId: 317218197
@lgeiger @rchen152
Replace list comprehension with generator expresion when calling any() (
28a2427 
#604)

This allows `any()` to return early without needing to iterate over the entire list.

Resolves #604

PiperOrigin-RevId: 317701319
@lgeiger @rchen152
Autodetect number of jobs with --jobs auto (#605)
274cb27 
This adds the possibility to autodetect the number of jobs based on the number of available CPU cores on the host system using `pytype --jobs auto`. This allows for a usage similar to [`pytest-xdist`](https://github.com/pytest-dev/pytest-xdist#speed-up-test-runs-by-sending-tests-to-multiple-cpus) which can be useful when using `pytype` in scripts that might run on different systems.

Resolves #605

PiperOrigin-RevId: 317924811
@rchen152
Fix Python 3.5 Travis test failures.
a26daae 
PiperOrigin-RevId: 317925038
@rchen152 rchen152 merged commit 7f6df73 into master Jun 23, 2020
@rchen152 rchen152 deleted the google_sync branch June 23, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rchen152 @googlebot @martindemello @Solumin @superbobry @lgeiger