Add toml as a dependency. #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchen152
added a commit
that referenced
this pull request
Jan 27, 2021
See #821 and its linked issue for context. The typeshed directory structure is changing significantly, so we need to update pytype accordingly. python/typeshed#2491 (comment) contains a nice diagram of the new structure. Note that I first developed this change on GitHub, then imported the PR. I'm asking for a review on the import (rather than the PR) because the import contains additional BUILD file changes (especially to third_party/py/toml - see the diffbase). PiperOrigin-RevId: 354138398
rchen152
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #820.