Skip to content
This repository has been archived by the owner on Aug 18, 2023. It is now read-only.

Hamiltonian tracing #156

Merged
merged 25 commits into from
Feb 2, 2022
Merged

Hamiltonian tracing #156

merged 25 commits into from
Feb 2, 2022

Conversation

zaqqwerty
Copy link
Contributor

@zaqqwerty zaqqwerty commented Jan 31, 2022 •
edited
Loading

Resolves #154

@zaqqwerty zaqqwerty marked this pull request as ready for review February 1, 2022 10:03
@zaqqwerty zaqqwerty requested a review from farice February 1, 2022 10:03
@zaqqwerty @farice
Enable tracing of QuantumCircuit __add__ (#131)
ebfb999
@zaqqwerty @farice
Weighted average utility (#134)
e213810
@zaqqwerty @farice
Add new style QHBMs (#125)
7b08ca3
@zaqqwerty @farice
Replace custom code with TF op (#141)
65ecb2a
@zaqqwerty @farice
Enable EBM seed (#143)
dfd6d3a
@zaqqwerty @farice
Add modular Hamiltonian expectation (#135)
03d8319
@zaqqwerty @farice
Energy expectation (#150)
a174e5b
@zaqqwerty @farice
Update TF, TFP, and TFQ versions (#152)
c43f4c1 
* try updating

* update python versions

* Tests passing

* increase tolerance for flaky test

* update setup.py
@zaqqwerty @farice
Utility function tests (#153)
83ce42a
@zaqqwerty @farice
Eager toggle decoration completion (#155)
ac13703
@zaqqwerty @farice
circuits test passing
bd5275a
@zaqqwerty @farice
expectation test failing
253554a
@zaqqwerty @farice
parameter change
975c453
@zaqqwerty @farice
more tests
88145a9
@zaqqwerty @farice
start refactor
ce1566b
@zaqqwerty @farice
add parameters to circuits
51e5350
@zaqqwerty @farice
test passing
570e144
@zaqqwerty @farice
format
9e3735b
@zaqqwerty @farice
remove lint
5d51ebf
@zaqqwerty @farice
revert superfluous changes
5263f77
@zaqqwerty @farice
Restart CI
b4d6860
@farice farice force-pushed the 154_hamiltonian_trace_permute branch from 5288b7a to b4d6860 Compare February 1, 2022 18:03
farice
farice previously approved these changes Feb 1, 2022
View reviewed changes
tests/hamiltonian_infer_test.py Show resolved Hide resolved
tests/hamiltonian_infer_test.py Outdated Show resolved Hide resolved
@farice
Copy link
Contributor

farice commented Feb 1, 2022 •
edited
Loading

jfme: what fixed the test compared to what you had before? I guess it was just to initialize the symbol values non-randomly?

@zaqqwerty
Copy link
Contributor Author

jfme: what fixed the test compared to what you had before? I guess it was just to initialize the symbol values non-randomly?

Two things:

  1. Changing the measured op so that the expectation values were different enough from zero (resolving the energy parameter test)
  2. Adding symbols to the circuit so that there were actually values to change (resolving the circuit parameter test)

@farice
Copy link
Contributor

farice commented Feb 2, 2022

Thanks for the explanation, all is clear

@farice farice merged commit 721b289 into google:main Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@farice farice farice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test traced Hamiltonian inference after changing energy and qnn parameters
2 participants
@zaqqwerty @farice