This repository has been archived by the owner on Aug 18, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
QMHL refactor #74
Merged
Merged
QMHL refactor #74
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
b2fd115
initial qmhl implementation
zaqqwerty b2051a8
added thetas grad
zaqqwerty 9beec14
start implementing phis
zaqqwerty 1ee0515
Merge branch 'main' into 18_qmhl_refactor
zaqqwerty 603a0c7
removed old QMHL routines
zaqqwerty dc0f5e5
squashing bugs
zaqqwerty 5514bf4
tracking down grad bug in qmhl
zaqqwerty f29a77e
Merge branch 'main' into 18_qmhl_refactor
zaqqwerty 7348c80
Merge branch 'main' into 18_qmhl_refactor
zaqqwerty 628ee7c
made operator an argument, still does not work
zaqqwerty 09f5e5a
test
zaqqwerty 42bfcc8
Merge branch 'main' into 18_qmhl_refactor
zaqqwerty b5a4eb4
QMHL zero gradient test passing
zaqqwerty 8378d1e
format
zaqqwerty 8f0a800
trying tf function
zaqqwerty d72579e
try non
zaqqwerty fb23dbe
Merge branch 'main' into 18_qmhl_refactor
zaqqwerty 87857e1
works without decoration now
zaqqwerty 2a6a6ee
use cached bitstrings
zaqqwerty f8dce25
format
zaqqwerty 1e9ae92
comments
zaqqwerty cb1eac8
format
zaqqwerty cb74d15
decorated for now
zaqqwerty db10f6b
Merge branch 'main' into 18_qmhl_refactor
zaqqwerty 9c56a69
Merge branch '18_qmhl_refactor' of https://github.com/zaqqwerty/qhbm-…
zaqqwerty 3e857de
patch
zaqqwerty 4db50a8
patch
zaqqwerty cc98a65
Merge branch 'main' into 18_qmhl_refactor
zaqqwerty e3da6ea
increase tolerance
zaqqwerty c03e16d
format
zaqqwerty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be entirely necessary, as we can simply access the ebm trainable variables via
self.ebm.trainable_variables
, and likewise for the qnn trainable variables?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not entirely necessary. But it is a convenience to match the notation we use in the theory. It also caches the call to trainable variables for later use, since the
trainable_variables
call searches recursively for variables each time.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See other comment regarding grads