Remove redundant null checks (#499)

google · May 28, 2019 · 1cc123f · 1cc123f
1 parent dbb723d
commit 1cc123f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/src/iterables/min_max.dart b/lib/src/iterables/min_max.dart
@@ -23,7 +23,7 @@ part of quiver.iterables;
 T max<T>(Iterable<T> i, [Comparator<T> compare]) {
   if (i.isEmpty) return null;
   final Comparator<T> _compare = compare ?? Comparable.compare;
-  return i.isEmpty ? null : i.reduce((a, b) => _compare(a, b) > 0 ? a : b);
+  return i.reduce((a, b) => _compare(a, b) > 0 ? a : b);
 }
 
 /// Returns the minimum value in [i], according to the order specified by the
@@ -35,7 +35,7 @@ T max<T>(Iterable<T> i, [Comparator<T> compare]) {
 T min<T>(Iterable<T> i, [Comparator<T> compare]) {
   if (i.isEmpty) return null;
   final Comparator<T> _compare = compare ?? Comparable.compare;
-  return i.isEmpty ? null : i.reduce((a, b) => _compare(a, b) < 0 ? a : b);
+  return i.reduce((a, b) => _compare(a, b) < 0 ? a : b);
 }
 
 /// Returns the minimum and maximum values in [i], according to the order