Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.equals() and .hashcode() missing for Pattern class #55

Closed
rkeytacked opened this issue Apr 12, 2018 · 1 comment
Closed

.equals() and .hashcode() missing for Pattern class #55

rkeytacked opened this issue Apr 12, 2018 · 1 comment

Comments

@rkeytacked
Copy link

The Pattern class should implement some (simple) .equals(Object) and .hashCode() methods to be able to be identified equal when being put into a Set.

Equality in this context can be as simple as the equality of the pattern string.
@alandonovan
Copy link
Contributor

The equivalence relation should incorporate the compilation flags too.

sjamesr added a commit to sjamesr/re2j that referenced this issue Apr 15, 2018
@sjamesr
Add Pattern.equals() and hashCode()
63700a3 
Fixes google#55.
@sjamesr sjamesr mentioned this issue Apr 15, 2018
Merged
sjamesr added a commit to sjamesr/re2j that referenced this issue Apr 15, 2018
@sjamesr
Add Pattern.equals() and hashCode()
b16a968 
Fixes google#55.
sjamesr added a commit to sjamesr/re2j that referenced this issue Apr 27, 2018
@sjamesr
Add Pattern.equals() and hashCode()
cc54c6e 
Fixes google#55.
sjamesr added a commit that referenced this issue Apr 27, 2018
@sjamesr
Add Pattern.equals() and hashCode()
9812767 
Fixes #55.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alandonovan @rkeytacked