tar2rpm allow specifying a build time stamp via the cli #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each diff test had separate file. Most of them 1-liners. When reading through the tests this requires another lookup to see "42" or "bash". Now this is all integrated into BUILD.bazel
Add a build_time flag which allows specifying the build timestamp for people who like that. To use the current time, you can use: ` --build_time $(date +%s)` I strongly recommend not doing that, because it makes the build change every time and hurt your caching and reproducibility, but people seem to need this. Also change the default timestamp to be empty to avoid the 2042 time. Fixes google#43
alexaguilera93
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a build_time flag which allows specifying the build timestamp for
people who like that.
To use the current time, you can use:
--build_time $(date +%s)I strongly recommend not doing that, because it makes the build change
every time and hurt your caching and reproducibility, but people seem to
need this.
Also change the default timestamp to be empty to avoid the 2042 time.
Fixes #43