Allowlist for directories #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
…ories to inlclude. Content is always included. fixes google#62
jarondl
force-pushed
the
dir_allowlist
branch
from
6a8bb86
to
8baba0b
Compare
|
/gcbrun |
|
/gcbrun |
| os.Exit(1) | ||
| } | ||
| if *useDirAllowlist { | ||
| al := map[string]bool{} |
There was a problem hiding this comment.
I think declaring as
var al map[string]bool
would be better, to avoid possibly unnecessary allocation.
| // Sometimes the tar has no uname and gname. RPM expects these to always exist. | ||
| owner := h.Uname | ||
| if owner == "" { | ||
| owner = "root" |
There was a problem hiding this comment.
Could defaulting to root be an issue here if a user is unpacking as root?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users reported issues with installing rpms that have directories from the core filesystem (such as /etc/, /var/, etc). This change adds the option in
tar2rpmand in the bazel rules, to only include certain directories. This talks about the directory itself, the content is always included.Fixes #62