Prepare pom.xml for publishing on sonatype-nexus-staging #29
Conversation
Follow instructions at * https://central.sonatype.org/publish/requirements/ * https://central.sonatype.org/publish/publish-maven/ Add the following sections: * url * licenses * developers * contributors * distributionManagement Configure plugins for javadoc, source, gpg and staging.
|
@aababilov Would you be able to add a README with the Maven coordinates as well to make it easier to discover? |
|
Good idea! We definitely need it. I can add this file. |
There was a problem hiding this comment.
Thanks! I don't have permissions to merge, but here are a couple small comments.
We will eventually want to submit this to the internal repo. Also eventually, "submit to the internal repo" should become our standard process (to keep Copybara happy). But given that I haven't set up Copybara as I've promised, and given that we want the repo to match the state you used to generate 2.0.0, it makes sense to me to merge it externally first.
pom.xml
Outdated
| <version>HEAD-SNAPSHOT</version> | ||
| <groupId>com.google.geometry</groupId> | ||
| <artifactId>s2-geometry</artifactId> | ||
| <version>2.0.0</version> |
There was a problem hiding this comment.
It may make sense to make the change to 2.0.0 in a separate commit (which you could then tag, as you'd said), keeping the version as HEAD-SNAPSHOT in main branch (as we've been doing for projects like Guava).
But we can always change to 2.0.0 now to keep things simple and then change back to HEAD-SNAPSHOT later, too.
(The only potential drawback to HEAD-SNAPSHOT that we've heard of so far is discussed in internal bug 195414312. In it, I note that "HEAD-SNAPSHOT" is currently rejected by the Java module system -- which s2-geometry doesn't use and probably doesn't need to, but it's something to be aware of.)
There was a problem hiding this comment.
It'll be particularly important to keep release branches to ensure client stability while giving ourselves a clean merge target for any urgent fixes or security issues, at least until the API evolution halts. In the meantime, let's keep this as some kind of snapshot label to avoid blessing this as any stable version.
There was a problem hiding this comment.
Eric, if you agree with Chris, I am reverting the version to HEAD-SNAPSHOT and I will set it to 2.0.0 in a separate commit.
| <organization>Google LLC</organization> | ||
| <organizationUrl>https://google.com</organizationUrl> | ||
| </contributor> | ||
| </contributors> | ||
|
|
||
| <properties> | ||
| <maven.compiler.source>1.8</maven.compiler.source> | ||
| <maven.compiler.target>1.8</maven.compiler.target> | ||
| <guava.version>25.1-jre</guava.version> |
There was a problem hiding this comment.
Git's deps tool seems to think that's the right target; is it right?
There was a problem hiding this comment.
You mean, guava 25.1-jre? Yes, it is right, it builds normally.
We will change it to 2.0.0 in a separate commit.
|
Thanks for review! PTAL. |
|
Merged. Thanks!
…On Thu, Aug 5, 2021 at 6:26 PM Alexei Ababilov ***@***.***> wrote:
Thanks for review! PTAL.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4DAAJIL3RPJMLURA7YC6TT3M23ZANCNFSM5BGF7RGA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Follow instructions at
Add the following sections:
Configure plugins for javadoc, source, gpg and staging.