Update .gitignore for CocoaPods #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file holds information about the exact dependency versions installed with `pod install`. In the case that one of the dependencies were updated with API breaking versions it would still be installed.
Don't ignore the xcworkspace created by CocoaPods. Since your dependencies, installed through CocoaPods, are required to build this project, you shouldn't ignore the required workspace.
|
My assumption for both of these is that the Rakefile runs 'pod install' and would handle this (coupled with specifying pod versions in the Podfile) but I'm not a CocoaPods expert so if this is easier, LGTM. |
russellhancox
added a commit
that referenced
this pull request
Nov 22, 2014
Update .gitignore for CocoaPods
|
Yes if you added specific versions in the |
|
Cool. Thanks for your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes 2 entries from the current
.gitignorePodfile.lock(also checking in the current version). Without this file, if FMDB was updated to 3.0 with breaking changes, the next time someone cloned this and ranpod installthey would install a broken version. Checking in this file ensures that pods will only be updated when runningpod update. In the future you may want to add more specific information about acceptable versions as well. Here's the relevant section of "Using CocoaPods" where we discuss this.xcworkspace. Since this project cannot be built without the dependencies installed via CocoaPods which go through this workspace, I'd recommend keeping this in the project. This will also show users who have just cloned the project that they are missing thePods.xcodeproj.