-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync clean all #1275
Merged
Merged
Sync clean all #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlw
added
enhancement
sync service
Issues related to the sync service / protocol
rules
santactl
configurator
transitive allowlisting
labels
Jan 19, 2024
pmarkowsky
previously approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
russellhancox
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
configurator
enhancement
rules
santactl
sync service
Issues related to the sync service / protocol
transitive allowlisting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
***IMPORTANT: This PR introduces a change in behavior!***
Currently, clean syncs result in the entire rules database being deleted and newly received rules being written. However this means that any transitive rules are also wiped out, causing pain for users.
This PR changes the meaning of clean syncs to instead only delete non-transitive rules before writing the newly received rules.
The following describes the new behavior:
santactl sync --clean
will only remove non-transitive rulessantactl sync --clean-all
is a new flag that will remove all rules (like--clean
before this PR)clean_sync
is now deprecatedclean_sync
is treated as only removing non-transitive rulessync_type
sync_type
preflight response key supports the following valuesnormal
- Only new rules will be added, existing rules will not be removedclean
- Remove non-transitive rules before writing new rulesclean_all
- Remove all rules before writing new rulesnormal
clean
orclean_all
action in the preflight responseclean_all
action even if the server only responded withclean
Fixes #1272