Added types for recording and storing performance metrics. #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds SNTMetricSet and various gauge and counter types to allow for exporting metrics such as CPU,Memory usage and other properties that are useful for tracking reliability and debugging. This is the first commit of a series to add support for monitoring systems.
tburgin
reviewed
Aug 11, 2021
| @interface SNTMetricSetTest : XCTestCase | ||
| @end | ||
|
|
||
| // Stub out NSDate's date method |
There was a problem hiding this comment.
clever :)
You could also do with https://ocmock.org/reference/#mocking-class-methods if you needed finer control.
…ky/santa into markowsky/metrics_class
tburgin
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds SNTMetricSet and various gauge and counter types to allow for
exporting metrics such as CPU,Memory usage and other properties that are useful
for tracking reliability and debugging.
This is the first commit of a series to add support for monitoring systems.
First part of a solution for #563