Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #92

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update README.md #92

wants to merge 2 commits into from

Conversation

drop189
Copy link

@drop189 drop189 commented Jul 25, 2024

Added an explanation that BuildConfig needs to be included in buildFeatures at the application level.

Added an explanation that BuildConfig needs to be included in buildFeatures at the application level.
Copy link

google-cla bot commented Jul 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Vt2049
Copy link

Vt2049 commented Jul 26, 2024

เพิ่มคำอธิบายว่าต้องรวม BuildConfig ไว้ใน buildFeatures ในระดับแอปพลิเคชัน

Edited the text. Now he describes the situation more precisely.
@kikoso kikoso self-assigned this Aug 27, 2024
Copy link
Collaborator

@kikoso kikoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, especially when the flag android.defaults.buildfeatures.buildconfig gets removed in Gradle 9.0

@Vt2049
Copy link

Vt2049 commented Sep 9, 2024

k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants