Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up task registry by using lazy properties #482

Merged
merged 0 commits into from
Mar 7, 2023

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Mar 3, 2023

Speed up task registry by using lazy properties

Functionality:
No change.
The preprocessors and metric_fn attributes of Task are now lazy. This is where many of the slow inspect calls were being invoked.

Speed:
Before making changes: ~120s for importing large bundle of tasks
After making changes: ~60s for importing large bundle of tasks
Unsurprisingly, different usages of these APIs result in differing performance, but no performance degradation is currently observed.

@copybara-service copybara-service bot force-pushed the test_513293702 branch 4 times, most recently from 8844873 to 8241b03 Compare March 7, 2023 17:00
@copybara-service copybara-service bot closed this Mar 7, 2023
@copybara-service copybara-service bot merged commit 364b494 into main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants