Speed up task registry by using lazy properties #482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up task registry by using lazy properties
Functionality:
No change.
The preprocessors and metric_fn attributes of Task are now lazy. This is where many of the slow
inspect
calls were being invoked.Speed:
Before making changes: ~120s for importing large bundle of tasks
After making changes: ~60s for importing large bundle of tasks
Unsurprisingly, different usages of these APIs result in differing performance, but no performance degradation is currently observed.