More-threadsafe construction of metric functions. #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_514858048
branch
5 times, most recently
from
e290501
to
63ab80f
Compare
copybara-service
bot
force-pushed
the
test_514858048
branch
from
63ab80f
to
ce28ad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More-threadsafe construction of metric functions.
Before, if multiple threads were accessing metric functions while they were uninitialized, there was a race condition, leading to instantiation multiple different times, possibly causing different metric functions to be stored inside e.g. score_metric_fns and predict_metric_fns that came from different instantiations.
Now, all of these are bottlenecked through a single cached_property, which is a cleaner design regardless of concurrency concerns.
functools.cached_property is not threadsafe[1], but this way, it shouldn't matter to us.
[1] https://discuss.python.org/t/finding-a-path-forward-for-functools-cached-property/23757