Tracking module-level seqio TaskRegistry use back to where the tasks were registered #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_513290892
branch
12 times, most recently
from
ea809ed
to
d7d897b
Compare
copybara-service
bot
force-pushed
the
test_513290892
branch
from
d7d897b
to
592a47b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking module-level seqio TaskRegistry use back to where the tasks were registered
Functionality:
1) New module task_registry_provenance_tracking module-level attribute that determines whether to track
the callsites of TaskRegistry.add calls.
When this attribute is turned on with task_registry_provenance_tracking.turn_on_tracking(), every time TaskRegistry.add is invoked, a portion of the call stack is retained, aiding a debugger's ability to determine "where was the code that registered this task?"
Speed:
Before making changes: 60 seconds for 200k tasks
After making changes: 80 seconds (but the default is off)