-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes needed for dEQP integration #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Left a few comments, some of which don't necessarily need addressing now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more comment. Regarding the CI failure, this looks like cppcheck is suddenly failing to compile. I assume this is because cppcheck was incorrectly not including a header somewhere and the system's C++ headers have now changed, exposing the bug. We could try updating cppcheck and/or we could make the cppcheck build always use clang's libc++ (which we download explicitly).
|
If you rebase, main now incorporates a temporary workaround for the cppcheck build problem. |
These changes allow to skip everything else but the shadertrap library. OpenGL wrapper header is used in place of gl32.h when compiling for dEQP.